[webkit-reviews] review denied: [Bug 55455] [EFL] HTML saving feature : [Attachment 93880] updated patch

Thu May 19 07:46:06 PDT 2011

Leandro Pereira <leandro at profusion.mobi> has denied Grzegorz
<g.czajkowski at samsung.com>'s request for review:
Bug 55455: [EFL] HTML saving feature
https://bugs.webkit.org/show_bug.cgi?id=55455

Attachment 93880: updated patch
https://bugs.webkit.org/attachment.cgi?id=93880&action=review

------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=93880&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:2040
> +    // Look for <html> tag. If it exists, the node contatins all document's
source.

What will happen if it is a XHTML page? WAP page?

> Source/WebKit/efl/ewk/ewk_frame.cpp:2062
> +    *frame_source = static_cast<char*>(malloc(sizeof(char) * source_length +
sizeof(char)));

sizeof(char) = 1 :)

> Source/WebKit/efl/ewk/ewk_frame.cpp:2116
> +	   if (eina_error_get()) {

eina_error_get() does not catches the possible failure in allocation due to
strdup() returning NULL, only eina-related stuff, like allocating a new node
for the list.

The error handling is fine, however; change just the error detection.