[webkit-reviews] review granted: [Bug 57048] http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html crashed once on Windows XP Debug (Tests) : [Attachment 94030] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 18 23:23:05 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 57048:
http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html
crashed once on Windows XP Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=57048

Attachment 94030: Patch
https://bugs.webkit.org/attachment.cgi?id=94030&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I'm going to say r+, since this is clearly an improvement, but the bug may need
to remain open until someone can test on Windows, and until the skipped tests
are re-enabled.

See also: <http://trac.webkit.org/changeset/81111> (where I unsuccessfully
tried to fix the crashes).


More information about the webkit-reviews mailing list