[webkit-reviews] review requested: [Bug 61098] Web Inspector: Provide inspector extension API to access timeline data : [Attachment 94008] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 18 17:21:57 PDT 2011


Michael Schneider <michschn at google.com> has asked  for review:
Bug 61098: Web Inspector: Provide inspector extension API to access timeline
data
https://bugs.webkit.org/show_bug.cgi?id=61098

Attachment 94008: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=94008&action=review

------- Additional Comments from Michael Schneider <michschn at google.com>
This proposed patch adds an webInspector.timeline API. It contains three event
sinks:
- onStarted: Listeners are notified when the backend starts collecting timeline
data.
- onStopped: Listeners are notified when the backend stops collecting timeline
data.
- onEventRecorded: Listeners are notified when a timeline record is collected.
The record is passed as first argument to the listener.

The start/stop is implicitly controlled if onEventRecorded listeners are
present.

For it to work, a TimelineManager was introduced to broadcast the events
received via InspectorBackend.registerDomainDispatcher("Timeline", ...). The
TimelinePanel now registers at the TimelineManager to receive events.


More information about the webkit-reviews mailing list