[webkit-reviews] review denied: [Bug 31721] Using jQuery to show/hide IMG elements crashes WebKit : [Attachment 94002] trivial patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Andrey Petrov
<andrey.petrov at gmail.com>'s request for review:
Bug 31721: Using jQuery to show/hide IMG elements crashes WebKit
https://bugs.webkit.org/show_bug.cgi?id=31721

Attachment 94002: trivial patch
https://bugs.webkit.org/attachment.cgi?id=94002&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94002&action=review

> Source/WebCore/ChangeLog:7
> +	   The isolated testcase can be found at the bug:
> +	   https://bugs.webkit.org/show_bug.cgi?id=31721#c5

This is insufficient. The test case should be included in the patch. As
mentioned by Ryosuke Niwa, we can write a test case for this bug using DRT and
the EventSender object. One such example that uses EventSender to click a
context menu item is
<http://trac.webkit.org/browser/trunk/LayoutTests/media/context-menu-actions.ht
ml>.

> Source/WebCore/ChangeLog:189
> +>>>>>>> .r86799

Merge conflict marker.