[webkit-reviews] review denied: [Bug 31721] Using jQuery to show/hide IMG elements crashes WebKit : [Attachment 93998] trivial patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 18 16:29:03 PDT 2011
Daniel Bates <dbates at webkit.org> has denied Andrey Petrov
<andrey.petrov at gmail.com>'s request for review:
Bug 31721: Using jQuery to show/hide IMG elements crashes WebKit
https://bugs.webkit.org/show_bug.cgi?id=31721
Attachment 93998: trivial patch
https://bugs.webkit.org/attachment.cgi?id=93998&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93998&action=review
This bug still affects Mac Safari as of version 5.0.5 (6533.21.1, r86784). But
I don't see any changes in this patch for the Mac port.
> Source/WebCore/ChangeLog:8
> + No new tests.
Can you elaborate on why we can't test this? It seems like we could at least
have a manual test case.
> Source/WebCore/ChangeLog:10
> + For platform code, do not assert nodes always have renderer.
It would be beneficial if you could elaborate a bit on this.
More information about the webkit-reviews
mailing list