[webkit-reviews] review granted: [Bug 61009] Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims : [Attachment 93977] Patch v5 - Anders wanted a rewrite using c-strings

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 61009: Processes spawned by SnowLeopard's WebProcess attempt to install
WebKit2 shims
https://bugs.webkit.org/show_bug.cgi?id=61009

Attachment 93977: Patch v5 - Anders wanted a rewrite using c-strings
https://bugs.webkit.org/attachment.cgi?id=93977&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93977&action=review

> Source/WebKit2/Platform/unix/EnvironmentUtilities.h:35
> +void stripValuesEndingWithString(const String& environmentVariable, const
String& value);

These could take CStrings or char*, it's up to you :)

> Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:46
> +#import <wtf/text/StringBuilder.h>

Not needed.