[webkit-reviews] review granted: [Bug 60680] Disable gc validation in release builds : [Attachment 93944] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 18 11:27:36 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 60680: Disable gc validation in release builds
https://bugs.webkit.org/show_bug.cgi?id=60680

Attachment 93944: Patch
https://bugs.webkit.org/attachment.cgi?id=93944&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93944&action=review

> Source/JavaScriptCore/wtf/Platform.h:1218
> +#ifndef NDEBUG
> +#if !defined(ENABLE_GC_VALIDATION)

Could use && instead of two #ifs. Or if you are going to use two #ifs you could
make them both #ifndef.


More information about the webkit-reviews mailing list