[webkit-reviews] review denied: [Bug 33179] [Qt] Enterkey to go to Newline does not work in the text area(in HTML form) : [Attachment 93664] updated Changelog

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 33179: [Qt] Enterkey to go to Newline does not work in the text area(in
HTML form)
https://bugs.webkit.org/show_bug.cgi?id=33179

Attachment 93664: updated Changelog
https://bugs.webkit.org/attachment.cgi?id=93664&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93664&action=review

LGTM, apart from...

> Source/WebCore/platform/qt/PlatformKeyboardEventQt.cpp:590
>      case Qt::Key_Backtab:
>	   if (event->text().isNull())
>	       return "\t";
> +    case Qt::Key_Enter:
> +	   if (event->text().isNull())
> +	       return "\r";

Missing break statement before the Qt::Key_Enter case.