[webkit-reviews] review requested: [Bug 19417] CSSParser should use custom "vector-like" class for managing properties : [Attachment 93934] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 18 10:38:30 PDT 2011


Andras Becsi <abecsi at webkit.org> has asked  for review:
Bug 19417: CSSParser should use custom "vector-like" class for managing
properties
https://bugs.webkit.org/show_bug.cgi?id=19417

Attachment 93934: proposed patch
https://bugs.webkit.org/attachment.cgi?id=93934&action=review

------- Additional Comments from Andras Becsi <abecsi at webkit.org>
Implement CSSPropertyContainer which on removal marks entries as empty and
sweeps them when the internal array grows too big. Use an internal HashMap to
be able to efficiently find entries by ID and automatically discard duplicate
properties.

In a follow-up patch CSSMutableStyleDeclaration can be simplified to use this
container too, instead of maintaining its own vector-based infrastructure for
managing parsed properties.


More information about the webkit-reviews mailing list