[webkit-reviews] review denied: [Bug 61024] Use placement new to allocate statics in BSS : [Attachment 93876] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied	review:
Bug 61024: Use placement new to allocate statics in BSS
https://bugs.webkit.org/show_bug.cgi?id=61024

Attachment 93876: Patch
https://bugs.webkit.org/attachment.cgi?id=93876&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I'm not sure if this is sufficiently safe. Nothing guarantees that size of an
object matches sizeof - the class may override operator new to allocate a
different amount of space. We used to do that with some strings to avoid buffer
allocation.

Besides, objects that are allocated this way won't work with fastMallocSize,
potentially triggering assertion failures.

r-, because this at least needs a more detailed risk/benefit analysis. I
suspect that downsides outweigh the benefits.