[webkit-reviews] review denied: [Bug 61070] Web Inspector: support for emulating element's pseudo class state in styleRulesForElement() : [Attachment 93928] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 61070: Web Inspector: support for emulating element's pseudo class state in
styleRulesForElement()
https://bugs.webkit.org/show_bug.cgi?id=61070

Attachment 93928: Patch
https://bugs.webkit.org/attachment.cgi?id=93928&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93928&action=review

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

Should be no OOPS here. I'll point you to the inspector tests offline so that
it was covered.

> Source/WebCore/css/CSSStyleSelector.cpp:1994
> +PassRefPtr<CSSRuleList> CSSStyleSelector::styleRulesForElement(Element* e,
bool authorOnly, bool includeEmptyRules, CSSRuleFilter filter, unsigned
emulateElementPseudoClass)

emulatePseudoClassMask ?

> Source/WebCore/css/CSSStyleSelector.cpp:2803
> +		   if (emulateElementPseudoClass != EmulateNone)

I'd suggest

if (emulatePseudoClassMask & EmulateFocus)
    return true;