[webkit-reviews] review granted: [Bug 10749] All animated SVG enum properties are now ints : [Attachment 93909] Patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 18 08:28:03 PDT 2011


Rob Buis <rwlbuis at gmail.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 10749: All animated SVG enum properties are now ints
https://bugs.webkit.org/show_bug.cgi?id=10749

Attachment 93909: Patch v3
https://bugs.webkit.org/attachment.cgi?id=93909&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93909&action=review

Looks good, r=me.

> Source/WebCore/ChangeLog:23
> +

I think we came up with a better comment on IRC:

alert(myClipPath.getAttribute('clipPathUnits')); <- without this patch it says
"1", now it says "userSpaceOnUse" as expected, and as other browsers do.


More information about the webkit-reviews mailing list