[webkit-reviews] review denied: [Bug 61035] Web Inspector: hide script location to ui location conversion details from ScriptsPanel : [Attachment 93902] Rebase.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 18 06:32:24 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 61035: Web Inspector: hide script location to ui location conversion
details from ScriptsPanel
https://bugs.webkit.org/show_bug.cgi?id=61035

Attachment 93902: Rebase.
https://bugs.webkit.org/attachment.cgi?id=93902&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93902&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:83
> +    scriptLocationToUILocation: function(sourceURL, sourceID, lineNumber,
columnNumber, callback)

sourceId

> Source/WebCore/inspector/front-end/ScriptsPanel.js:526
> +		   this._showSourceLine(sourceFileId, lineNumber);

We should not highlight line in case it was not specified in anchor.


More information about the webkit-reviews mailing list