[webkit-reviews] review denied: [Bug 61035] Web Inspector: add ScriptLocation and UILocation classes and hide conversions in model. : [Attachment 93896] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 18 04:35:26 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 61035: Web Inspector: add ScriptLocation and UILocation classes and hide
conversions in model.
https://bugs.webkit.org/show_bug.cgi?id=61035
Attachment 93896: Patch.
https://bugs.webkit.org/attachment.cgi?id=93896&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93896&action=review
> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:615
> +WebInspector.ScriptLocation = function(url, sourceID, lineNumber,
columnNumber)
These should be defined near WebInspector.SourceMapping and should actually be
used there.
More information about the webkit-reviews
mailing list