[webkit-reviews] review denied: [Bug 60897] Implement toImageData() in QtWebKit Bridge : [Attachment 93660] implement toImageData() in Qt bridge

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Andrew Wason
<rectalogic at rectalogic.com>'s request for review:
Bug 60897: Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897

Attachment 93660: implement toImageData() in Qt bridge 
https://bugs.webkit.org/attachment.cgi?id=93660&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93660&action=review

> Source/WebCore/bridge/qt/qt_pixmapruntime.cpp:100
> +    void copyPixels(QImage image, int width, int height, unsigned char*
destPixels)

This code looks very inefective.

What about using QImage::convertToFormat() to always convert to
QImage::Format_ARGB32, and then do the byte shifting? Qt already has optimized
color conversions fonctions for plenty of formats.