[webkit-reviews] review denied: [Bug 60254] Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support : [Attachment 93888] Patch v1

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 60254: Remove platform layering violation: TextRun stores RenderObjects for
SVG Fonts support
https://bugs.webkit.org/show_bug.cgi?id=60254

Attachment 93888: Patch v1
https://bugs.webkit.org/attachment.cgi?id=93888&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93888&action=review

> Source/WebCore/platform/graphics/TextRun.h:107
> +	   virtual bool isRenderTextRun() const { return false; }

This feels very strange.  You shouldn't be asking this "extra data" member what
type the thing holding onto it is.  This is all one big hack around not having
virtual dispatch for these stack objects it seems.

Does the TextRun itself need to have these members?  Or can there be a
SVGTextRun which has a TextRun instead of is-a TextRun?