[webkit-reviews] review granted: [Bug 61003] Change RenderTextControl::hitInnerTextElement to use IntPoint : [Attachment 93843] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 61003: Change RenderTextControl::hitInnerTextElement to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61003

Attachment 93843: Patch
https://bugs.webkit.org/attachment.cgi?id=93843&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93843&action=review

> Source/WebCore/rendering/RenderTextControl.cpp:473
> +    result.setLocalPoint(pointInContainer - IntSize(tx + x() +
m_innerText->renderBox()->x(),
> +						       ty + y() +
m_innerText->renderBox()->y()));

We shouldn’t line up like this. The style guide specifically says not to.