[webkit-reviews] review canceled: [Bug 37319] [Qt] tst_QWebFrame::overloadedSlots() fails : [Attachment 92540] Patch

[bugzilla-daemon at webkit.org]

Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org> has canceled Noam
Rosenthal <noam.rosenthal at nokia.com>'s request for review:
Bug 37319: [Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

Attachment 92540: Patch
https://bugs.webkit.org/attachment.cgi?id=92540&action=review

------- Additional Comments from Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>
I asked Noam to pick up this one. This patch is on top of another patch for bug
60984, so will not compile yet.

A summary of the changes:

- Be more agressive when converting JSElement to QWebElement. If we have no
hint for a JSElement, offer one. Once we get a QWebElement, identify it as a
"perfect match" (dist = 0). This change was present in the latest version of
Noam's patch.

- Remove the special handling for 'document' object. The 'document' vs.
'document.documentElement' is complicated enough, as well as our logic for
choosing the right slot. This implicit conversion was added for the sake of DRT
nodesFromRect, but we can use QVariantMap conversion and pick the
'documentElement' instead.

- This patch depends on the other because when creating the QVariantMap we hit
into situation that an exception 'leaks' from the conversion function.

The layout test and the autotests mentioned all pass.