[webkit-reviews] review denied: [Bug 60991] WebKit2: Needs API to set a custom drop target : [Attachment 93832] [PATCH] Fix v2

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 60991: WebKit2: Needs API to set a custom drop target
https://bugs.webkit.org/show_bug.cgi?id=60991

Attachment 93832: [PATCH] Fix v2
https://bugs.webkit.org/attachment.cgi?id=93832&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93832&action=review

> Source/WebKit2/UIProcess/win/WebView.cpp:1132
> +void WebView::setCustomDropTarget(IDropTarget* dropTarget)
> +{
> +    ::RevokeDragDrop(m_window);
> +
> +    if (dropTarget)
> +	   ::RegisterDragDrop(m_window, dropTarget);
> +    else
> +	   ::RegisterDragDrop(m_window, this);
> +}

This won't work correctly if m_window has been destroyed or the page has
already been closed. We shouldn't do anything in those cases.