[webkit-reviews] review denied: [Bug 60991] WebKit2: Needs API to set a custom drop target : [Attachment 93821] [PATCH] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 17 14:56:06 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 60991: WebKit2: Needs API to set a custom drop target
https://bugs.webkit.org/show_bug.cgi?id=60991

Attachment 93821: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=93821&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93821&action=review

> Source/WebKit2/UIProcess/win/WebView.cpp:1128
> +void WebView::setCustomDropTarget(IDropTarget* dropTarget)
> +{
> +    ::RevokeDragDrop(m_window);
> +    ::RegisterDragDrop(m_window, dropTarget);
> +}

If someone passes in 0 here, we should set the drop target back to our standard
one. Otherwise clients will have no way to clear their custom drop target.


More information about the webkit-reviews mailing list