[webkit-reviews] review granted: [Bug 54636] Area element doesn't update region when dynamically altered : [Attachment 93764] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 17 12:16:08 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 54636: Area element doesn't update region when dynamically altered
https://bugs.webkit.org/show_bug.cgi?id=54636

Attachment 93764: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=93764&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93764&action=review

> LayoutTests/fast/images/script-tests/imagemap-dynamic-area-updates.js:7
> +image.setAttribute('usemap', '#m');

So long since I have used this :-)

> LayoutTests/fast/images/script-tests/imagemap-dynamic-area-updates.js:72
> +var successfullyParsed = true;

Who sets this to false in case of failure? Is that handled by the wrapper?


More information about the webkit-reviews mailing list