[webkit-reviews] review denied: [Bug 60377] [WK2][Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux : [Attachment 93321] Trying Fix again

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 17 12:13:12 PDT 2011


Andreas Kling <kling at webkit.org> has denied Idrees <sidreesshah at hotmail.com>'s
request for review:
Bug 60377: [WK2][Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on
Linux
https://bugs.webkit.org/show_bug.cgi?id=60377

Attachment 93321: Trying Fix again
https://bugs.webkit.org/attachment.cgi?id=93321&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93321&action=review

> Source/WebKit2/Shared/WebPreferencesStore.h:61
> -    macro(WebGLEnabled, webGLEnabled, Bool, bool, false) \
> +    macro(WebGLEnabled, webGLEnabled, Bool, bool, true) \

This enables WebGL for all WK2 ports, that kind of change should not be done
behind a bug marked [Qt].
Not to mention that it has nothing to do with the failing test this bug is
about.


More information about the webkit-reviews mailing list