[webkit-reviews] review granted: [Bug 60595] Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess : [Attachment 93802] Patch #4 - Implement the shim, and have the UIProcess do the work.

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 60595: Mac WebKit2 WebProcess needs a shim to make prompts appear to be
from the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=60595

Attachment 93802: Patch #4 - Implement the shim, and have the UIProcess do the
work.
https://bugs.webkit.org/attachment.cgi?id=93802&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93802&action=review

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:275
> +    OwnPtr<SecItemAPIContext> context = adoptPtr(new SecItemAPIContext);    


I think you can allocate the SecItemAPIContext on the stack here.

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:303
> +    OwnPtr<SecItemAPIContext> context = adoptPtr(new SecItemAPIContext);    


Ditto.

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:330
> +    OwnPtr<SecItemAPIContext> context = adoptPtr(new SecItemAPIContext);    


Ditto.

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:356
> +    OwnPtr<SecItemAPIContext> context = adoptPtr(new SecItemAPIContext);    


Ditto.