[webkit-reviews] review denied: [Bug 60687] [GTK] Replace GdkRectangle by cairo_rectangle_int_t : [Attachment 93793] Proposed Patch2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 17 10:50:54 PDT 2011


Martin Robinson <mrobinson at webkit.org> has denied Joone Hur
<joone.hur at collabora.co.uk>'s request for review:
Bug 60687: [GTK] Replace GdkRectangle by cairo_rectangle_int_t
https://bugs.webkit.org/show_bug.cgi?id=60687

Attachment 93793: Proposed Patch2
https://bugs.webkit.org/attachment.cgi?id=93793&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93793&action=review

I'm not sure I understand this patch. While depending on a newer version of
Cairo means that we can use cairo_rect_t and cairo_region_t, it doesn't mean we
can use it with old versions of GTK+.

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:639
> +    gdk_cairo_region(cr, (GdkRegion*)reg);

Why are you casting here. Isn't this incorect on old versions of GTK+? I don't
think it's right to cast between a cairo region and GdkRegion.

> Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:432
> -    if (gdk_rectangle_intersect(&area, &sourceRect, &moveRect)) {
> -	   GdkRegion* moveRegion = gdk_region_rectangle(&moveRect);
> +    if (gdk_rectangle_intersect((GdkRectangle*)&area,
(GdkRectangle*)&sourceRect, (GdkRectangle*)&moveRect)) {
> +	   GdkRegion* moveRegion =
gdk_region_rectangle((GdkRectangle*)&moveRect);
>	   gdk_window_move_region(window, moveRegion, delta.width(),
delta.height());

I have the same feeling here!


More information about the webkit-reviews mailing list