[webkit-reviews] review denied: [Bug 60900] Web Inspector: refactoring: ScriptDebugListener::didParseSource has too many parameters. : [Attachment 93676] Fix warning.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 17 07:31:09 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 60900: Web Inspector: refactoring: ScriptDebugListener::didParseSource has
too many parameters.
https://bugs.webkit.org/show_bug.cgi?id=60900

Attachment 93676: Fix warning.
https://bugs.webkit.org/attachment.cgi?id=93676&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93676&action=review

> Source/WebCore/inspector/ScriptDebugListener.h:50
> +	       , endColumn(0)

linesCount(0) is missing

> Source/WebCore/inspector/ScriptDebugListener.h:62
> +	   int linesCount;

This field is never used, please remove it.


More information about the webkit-reviews mailing list