[webkit-reviews] review granted: [Bug 60440] [Qt] Redirection of HTTP POST (3xx) incorrectly includes original POST data : [Attachment 93726] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 17 01:50:53 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Luiz Agostini
<luiz at webkit.org>'s request for review:
Bug 60440: [Qt] Redirection of HTTP POST (3xx) incorrectly includes original
POST data
https://bugs.webkit.org/show_bug.cgi?id=60440

Attachment 93726: patch
https://bugs.webkit.org/attachment.cgi?id=93726&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93726&action=review

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:619
> +    if (m_method != QNetworkAccessManager::PostOperation && m_method !=
QNetworkAccessManager::PutOperation) {
> +	   m_request.setHeader(QNetworkRequest::ContentTypeHeader, QVariant());


I would add a comment here like: clearing Contents-length and Contents-type
here, so make sure they are ...


More information about the webkit-reviews mailing list