[webkit-reviews] review requested: [Bug 47980] Add the feature "Add as search engine..." in a search text field context menu for chromium : [Attachment 93734] Proposed Patch V8

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 16 20:26:36 PDT 2011


philippe.beauchamp at gmail.com has asked	for review:
Bug 47980: Add the feature "Add as search engine..." in a search text field
context menu for chromium
https://bugs.webkit.org/show_bug.cgi?id=47980

Attachment 93734: Proposed Patch V8
https://bugs.webkit.org/attachment.cgi?id=93734&action=review

------- Additional Comments from philippe.beauchamp at gmail.com
Updated Patch. 
-Removed comments
-Removed WebCore namespace qualifier 

Style error is false positive for Alphabetical Sorting problem
***
#include "HitTestResult.h"
#include "HTMLFormElement.h"
	   ^
***
in \Tools\Scripts\webkitpy\style\checkers\cpp.py:2703
if previous_header_type == _OTHER_HEADER and previous_line.strip() >
line.strip():

should be something like:
if previous_header_type == _OTHER_HEADER and previous_line.strip().lower() >
line.strip().lower():

I'll report to check-webkit-style


More information about the webkit-reviews mailing list