[webkit-reviews] review denied: [Bug 60936] Add currentTickCount() to get monotonically increasing time : [Attachment 93720] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 60936: Add currentTickCount() to get monotonically increasing time
https://bugs.webkit.org/show_bug.cgi?id=60936

Attachment 93720: Patch
https://bugs.webkit.org/attachment.cgi?id=93720&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93720&action=review

> Source/JavaScriptCore/wtf/CurrentTime.cpp:302
> +	   return lastTickCount;

1. This is clearly wrong since lastTickCount isn't set.
2. I find it sad that we have two copies of this code.
3. How does this work in the presence of multiple threads?

Ditto for the other instance of this code.