[webkit-reviews] review granted: [Bug 60871] HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max. : [Attachment 93724] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 60871: HTML5 Number Spinbox displays a 0 in situations where a 0 is not
between the min and max.
https://bugs.webkit.org/show_bug.cgi?id=60871

Attachment 93724: Patch
https://bugs.webkit.org/attachment.cgi?id=93724&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93724&action=review

>
LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js:245
> +shouldBe('stepUpExplicitBounds(-4, 4, 1, "")', '"1"');
> +shouldBe('stepDownExplicitBounds(-4, 4, 1, "")', '"-1"');
> +shouldBe('stepDownExplicitBounds(0, 4, 1, "")', '"0"');
> +shouldBe('stepUpExplicitBounds(-4, 0, 1, "")', '"0"');
> +shouldBe('stepDownExplicitBounds(1, 4, 1, "")', '"1"');
> +shouldBe('stepUpExplicitBounds(1, 4, 1, "")', '"1"');
> +shouldBe('stepDownExplicitBounds(-4, -1, 1, "")', '"-1"');
> +shouldBe('stepUpExplicitBounds(-4, -1, 1, "")', '"-1"');
> +shouldBe('stepUpExplicitBounds(-100, null, 3, "")', '"2"');
> +shouldBe('stepDownExplicitBounds(-100, null, 3, "")', '"-1"');
> +shouldBe('stepUpExplicitBounds(1, 4, 1, 0)', '"1"');
> +shouldBe('stepDownExplicitBounds(1, 4, 1, 0)', '"0"');
> +shouldBe('stepDownExplicitBounds(-4, -1, 1, 0)', '"-1"');
> +shouldBe('stepUpExplicitBounds(-4, -1, 1, 0)', '"0"');
> +shouldBe('stepUpExplicitBounds(-100, null, 3, 3)', '"5"');
> +shouldBe('stepDownExplicitBounds(-100, null, 3, 3)', '"2"');

nit: The function arguments should be strings unless null.
Specifying numbers causes extra conversion.