[webkit-reviews] review denied: [Bug 60719] Split canvas from LayerTilerChromium : [Attachment 93647] proposed patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 60719: Split canvas from LayerTilerChromium
https://bugs.webkit.org/show_bug.cgi?id=60719

Attachment 93647: proposed patch
https://bugs.webkit.org/attachment.cgi?id=93647&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93647&action=review

This is looking pretty good now.  I'm still a bit uneasy about the const
PlatformImage& on ImageLayerTextureUpdater, but that doesn't have to be
resolved in this patch.  I don't feel strongly about the update() names.  Needs
a merge and a few nits but I think we're about there.

> Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp:73
> +	   return IntRect(IntPoint(0, 0), m_image.size());

nit: you can just do IntPoint(). this does not seem like a very useful utility
function

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:63
> +#if USE(SKIA)
> +class SkCanvas;
> +#endif

If you merge up to ToT this won't be needed any more.

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:156
> +    explicit LayerRendererChromium(PassRefPtr<GraphicsContext3D>,
PassOwnPtr<LayerPainterChromium> contentPaint);

nit: explicit isn't needed since this c'tor take stwo arguments (you did not
break this, but since you're in here anyway might as well clean it up)

> Source/WebCore/platform/graphics/chromium/LayerTextureSubImage.h:42
> +    LayerTextureSubImage(bool useMapSubForUpload);

need explicit here