[webkit-reviews] review granted: [Bug 60920] editing/deleting/5091898.html should be renamed and converted to a dump-as-markup test : [Attachment 93690] converted the test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 16 14:06:31 PDT 2011
Enrica Casucci <enrica at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 60920: editing/deleting/5091898.html should be renamed and converted to a
dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=60920
Attachment 93690: converted the test
https://bugs.webkit.org/attachment.cgi?id=93690&action=review
------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93690&action=review
I would prefer if you renamed the file instead of removing and adding, simply
to preserve the change history.
>
LayoutTests/editing/deleting/delete-line-break-before-underlined-content.html:6
> <script>
Since you're rewriting this, I would add the instructions to run the test
manually, just for the sake of clarity.
More information about the webkit-reviews
mailing list