[webkit-reviews] review denied: [Bug 60827] [GTK] Implement GraphicsContextCairo::imageInterpolationQuality(). : [Attachment 93601] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 60827: [GTK] Implement GraphicsContextCairo::imageInterpolationQuality().
https://bugs.webkit.org/show_bug.cgi?id=60827

Attachment 93601: Patch
https://bugs.webkit.org/attachment.cgi?id=93601&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93601&action=review

Nice! I have a few comments below. In general, I think this patch needs a bit
more context either in the ChangeLog or in the bug report. Are you just filling
out a stub here?

> Source/WebCore/ChangeLog:8
> +	   Implement GraphicsContextCairo::imageInterpolationQuality.

Might make sense to describe how this affects drawing performance or give more
information about what prompted this change.

> Source/WebCore/ChangeLog:16
> +	   * platform/graphics/cairo/GraphicsContextCairo.cpp:
> +	   (WebCore::GraphicsContext::setImageInterpolationQuality):
> +	   (WebCore::GraphicsContext::imageInterpolationQuality):
> +	   * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
> +	   * platform/graphics/cairo/PlatformContextCairo.cpp:
> +	   (WebCore::PlatformContextCairo::drawSurfaceToContext):
> +

Please fill these out.

>
Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:10
5
> +    InterpolationQuality imageInterpolationQuality;

It makes more sense to have this as a member of PlatformContextCairo, don't you
think?