[webkit-reviews] review granted: [Bug 60908] JSWeakObjectMap finalisation may occur while gc is in inconsistent state : [Attachment 93670] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 60908: JSWeakObjectMap finalisation may occur while gc is in inconsistent
state
https://bugs.webkit.org/show_bug.cgi?id=60908

Attachment 93670: Patch
https://bugs.webkit.org/attachment.cgi?id=93670&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93670&action=review

Please file a bug to track the better long-term change we discussed, which
makes weak maps reference-counted in the API, based on a linked-on-or-after
check

> Source/JavaScriptCore/runtime/JSGlobalObject.h:116
> +	   static JS_EXPORTDATA WeakMapFinalizer s_weakMapFinalizer;

These names really should be plural -- "WeakMapsFinalizer,
s_weakMapsFinalizer", etc.