[webkit-reviews] review granted: [Bug 60862] Convert api tester over to using gtest expectations directly : [Attachment 93665] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 16 10:37:40 PDT 2011


David Levin <levin at chromium.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 60862: Convert api tester over to using gtest expectations directly
https://bugs.webkit.org/show_bug.cgi?id=60862

Attachment 93665: Patch
https://bugs.webkit.org/attachment.cgi?id=93665&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93665&action=review

> Tools/TestWebKitAPI/PlatformUtilities.h:63
> +static inline ::testing::AssertionResult assertWKStrigEqual(const char*
expected_expression, const char* actual_expression, T expected, U actual)

typo: strig

I'm surprised that EXPECT_STREQ doesn't work for you. (I see you used it with
char* inside of TEST(WebKit2, WKString)


More information about the webkit-reviews mailing list