[webkit-reviews] review denied: [Bug 47980] Add the feature "Add as search engine..." in a search text field context menu for chromium : [Attachment 90932] Proposed Patch V7

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied
philippe.beauchamp at gmail.com's request for review:
Bug 47980: Add the feature "Add as search engine..." in a search text field
context menu for chromium
https://bugs.webkit.org/show_bug.cgi?id=47980

Attachment 90932: Proposed Patch V7
https://bugs.webkit.org/attachment.cgi?id=90932&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90932&action=review

Please address style elf's feedback.

> Source/WebKit/chromium/src/WebSearchableFormData.cpp:151
> +WebCore::HTMLInputElement* findSuitableSearchInputElement(const
HTMLFormElement* form)

Don't need WebCore namespace qualifier here.

> Source/WebKit/chromium/src/WebSearchableFormData.cpp:165
> +	   // Return nothing if an element is not in the default state
> +	   // Return nothing if a text area is found.

This comment just repeats what the code does. Don't need it here.