[webkit-reviews] review denied: [Bug 60888] Web Inspector: debuggerWasEnabled notification should not be send to frontend on navigation. : [Attachment 93645] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 16 08:23:18 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 60888: Web Inspector: debuggerWasEnabled notification should not be send to
frontend on navigation.
https://bugs.webkit.org/show_bug.cgi?id=60888

Attachment 93645: Patch.
https://bugs.webkit.org/attachment.cgi?id=93645&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93645&action=review

> Source/WebCore/inspector/InspectorController.h:-118
> -    void disableDebugger();

Please make sure this doesn't break Safari. I only see Start debugging... but
please double check.

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:144
> +    m_inspectorState->setBoolean(DebuggerAgentState::debuggerEnabled,
false);

After front-end reopening debugger will be off in Safari. r- for this.


More information about the webkit-reviews mailing list