[webkit-reviews] review granted: [Bug 60886] Add the ability for a plug-in controller to short-circuit calls to NPN_Invoke : [Attachment 93643] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 60886: Add the ability for a plug-in controller to short-circuit calls to
NPN_Invoke
https://bugs.webkit.org/show_bug.cgi?id=60886

Attachment 93643: Patch
https://bugs.webkit.org/attachment.cgi?id=93643&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93643&action=review

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:284
> +bool PluginControllerProxy::tryToShortCircuitInvoke(NPObject*, NPIdentifier
methodName, const NPVariant* arguments, uint32_t argumentCount, NPVariant*
result)

Will these unused variables be a problem?

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:543
> +bool PluginControllerProxy::tryToShortCircuitEvaluate(NPObject* npObject,
const String& scriptString, NPVariant* result)

Will these unused variables be a problem?