[webkit-reviews] review denied: [Bug 58730] currentColor not supported in CSS gradients : [Attachment 93609] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied David Barr
<davidbarr at chromium.org>'s request for review:
Bug 58730: currentColor not supported in CSS gradients
https://bugs.webkit.org/show_bug.cgi?id=58730

Attachment 93609: Patch
https://bugs.webkit.org/attachment.cgi?id=93609&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93609&action=review

> LayoutTests/fast/css/linear-gradient-currentcolor.html:5
> +    color:red;

Please don't have visible red in a passing test. It would be better to use
green, and maybe put two color stops next to eachother to get a sharp edge
that's less likely to suffer from platform differences.

Spaces after colons please.

> Source/WebCore/ChangeLog:8
> +	   https://bugs.webkit.org/show_bug.cgi?id=58730
> +
> +	   Test: fast/css/linear-gradient-currentcolor.html

This needs some text saying how you fixed the issue.

> Source/WebCore/css/CSSGradientValue.cpp:159
> +	       stops[i].color =
renderer->document()->styleSelector()->getColorFromPrimitiveValue(color);

I don't get it. getColorFromPrimitiveValue() already looks for
CSSValueCurrentcolor.