[webkit-reviews] review granted: [Bug 60624] Web Inspector: use InstrumentingAgents to access agents from InspectorInstrumentation : [Attachment 93636] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 16 06:02:45 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 60624: Web Inspector: use InstrumentingAgents to access agents from
InspectorInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=60624

Attachment 93636: Patch
https://bugs.webkit.org/attachment.cgi?id=93636&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93636&action=review

> Source/WebCore/inspector/InspectorInstrumentation.h:715
> +    if (hasFrontends())

replace with the macro?

> Source/WebCore/inspector/InspectorInstrumentation.h:723
> +    if (hasFrontends())

ditto

> Source/WebCore/inspector/InspectorInstrumentation.h:731
> +    if (hasFrontends())

ditto


More information about the webkit-reviews mailing list