[webkit-reviews] review denied: [Bug 60871] HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max. : [Attachment 93620] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 16 02:58:09 PDT 2011


Kent Tamura <tkent at chromium.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 60871: HTML5 Number Spinbox displays a 0 in situations where a 0 is not
between the min and max.
https://bugs.webkit.org/show_bug.cgi?id=60871

Attachment 93620: Patch
https://bugs.webkit.org/attachment.cgi?id=93620&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93620&action=review

> LayoutTests/fast/forms/numeric-input-spin.html:48
> +//	  - The value should be the minimum value for both keyDown and keyUp.

Don't call them keydown / keyup.  Keydown and keyup are the names of DOM
events.

> Source/WebCore/html/HTMLInputElement.cpp:1466
> +	   int nextDiff = step * n;
> +	   if (current < m_inputType->minimum() - nextDiff)
> +	       current = m_inputType->minimum() - nextDiff;

This looks tricky.  But I understand you want to use the following
step-rounding and the event dispatching.  So I think this is acceptable.

> Source/WebCore/html/HTMLInputElement.cpp:1475
> -	   if (stepMismatch(currentStringValue)) {
> +	   if (stepMismatch(value())) {

Instead of this change, we had better do currentStringValue=value() just after
setValueAsNumber().
Anyway, this also fixes another bug http://crbug.com/76046 , right?


More information about the webkit-reviews mailing list