[webkit-reviews] review granted: [Bug 60867] Enable strict mode for OwnPtr and PassOwnPtr : [Attachment 93623] patch for fixing the build break
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 16 01:50:56 PDT 2011
Adam Barth <abarth at webkit.org> has granted review:
Bug 60867: Enable strict mode for OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60867
Attachment 93623: patch for fixing the build break
https://bugs.webkit.org/attachment.cgi?id=93623&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93623&action=review
> Source/WebCore/platform/graphics/gtk/GraphicsContext3DGtk.cpp:31
> +#include "PassOwnPtr.h"
This should be
#include <wtf/PassOwnPtr.h>
> Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp:21
> +#include "PassOwnPtr.h"
This should be
#include <wtf/PassOwnPtr.h>
> Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp:94
> return 0;
This should be "return nullptr" or else it will break soon again. (The same
applies to the other instances of "return 0" in this function.)
More information about the webkit-reviews
mailing list