[webkit-reviews] review requested: [Bug 60875] [SOUP] Abnormal operation if server sends 5xx status code without HTTP body : [Attachment 93625] Handle status code 5xx after receiving HTTP body

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 16 01:48:25 PDT 2011


Keunsoon Lee <keunsoon.lee at samsung.com> has asked  for review:
Bug 60875: [SOUP] Abnormal operation if server sends 5xx status code without
HTTP body
https://bugs.webkit.org/show_bug.cgi?id=60875

Attachment 93625: Handle status code 5xx after receiving HTTP body
https://bugs.webkit.org/attachment.cgi?id=93625&action=review

------- Additional Comments from Keunsoon Lee <keunsoon.lee at samsung.com>
Handle status code 5xx after receiving HTTP body
    - Background
	1) Webkit soup port premises that server always sends error page in
case of status code 5xx.
	2) But, sometimes there is no HTTP body for error page in that case.
    - Modified algorithm;
	1) libsoup sends status code 5xx (server error)
	2) Webkit soup port orders to accumulate HTTP body chunks to libsoup.
	3) Webkit soup port ignores gotHeadersCallback, contentSniffedCallback
and gotChunkCallback.
	4) Webkit soup port checks there is HTTP body or not on
sendRequestCallback and;
	    4-1) if there is HTTP body, calls didReceiveResponse()
	    4-2) if there is no HTTP body, calls didFail()


More information about the webkit-reviews mailing list