[webkit-reviews] review denied: [Bug 60871] HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max. : [Attachment 93614] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 60871: HTML5 Number Spinbox displays a 0 in situations where a 0 is not
between the min and max.
https://bugs.webkit.org/show_bug.cgi?id=60871

Attachment 93614: Patch
https://bugs.webkit.org/attachment.cgi?id=93614&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93614&action=review

> Source/WebCore/html/HTMLInputElement.cpp:339
> -void HTMLInputElement::applyStep(double count, ExceptionCode& ec)
> +void HTMLInputElement::applyStep(double count, bool clearedByDefault,
ExceptionCode& ec)

I don't think we need to handle such cases in applyStep().  We can handle such
cases only in stepUpFromRenderer().
Also, a bool function parameter is not recommended.