[webkit-reviews] review granted: [Bug 60860] Simplify backtracking in YARR JIT : [Attachment 93613] Almost identical to the old patch, fix stylebot issues, remove 'what' comments, renamed m_optimized to m_isDeadCode, add backtrackTermDefault.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 16 00:07:14 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 60860: Simplify backtracking in YARR JIT
https://bugs.webkit.org/show_bug.cgi?id=60860

Attachment 93613: Almost identical to the old patch, fix stylebot issues,
remove 'what' comments, renamed m_optimized to m_isDeadCode, add
backtrackTermDefault.
https://bugs.webkit.org/attachment.cgi?id=93613&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me, modulo Michael's comments above.

Would be good to come up with a fix to the o(n^2) issue soon.

These YarrOps really lend themselves to a future refactoring that makes them
objects with virtual generate / backtrack functions.


More information about the webkit-reviews mailing list