[webkit-reviews] review denied: [Bug 60518] Expose willStartLiveResize and willEndLiveResize in WebView : [Attachment 93519] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Sailesh Agrawal
<sail at chromium.org>'s request for review:
Bug 60518: Expose willStartLiveResize and willEndLiveResize in WebView
https://bugs.webkit.org/show_bug.cgi?id=60518

Attachment 93519: Patch
https://bugs.webkit.org/attachment.cgi?id=93519&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93519&action=review

Sorry if it comes off as though I'm being nit-picky here.  I just think it is
important that the API makes sense.

> Source/WebKit/chromium/public/WebWidget.h:58
> +    // Called when the user begins to drag the resizer.

You are still leaving things mysterious for the reader to guess what you mean.
I think you mean that willStartLiveResize will be followed by a sequence of
calls to resize(), but you don't say that.  Am I interpreting this API
correctly?
If so, please add a comment to clarify this.

Is it required that this API only be used when resizing using the "resizer"? 
Why
is the effect particular to that way of resizing?  what if there are other ways

of allowing a user gesture to actuate a "live resize" sequence?

I'm guessing (so please clarify), but I think you just want to tell WebKit to
treat a sequence of resize() calls as related to a single user gesture.  Maybe
that does not need to be particular to the "resizer" UI?