[webkit-reviews] review granted: [Bug 60862] Convert api tester over to using gtest expectations directly : [Attachment 93597] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 15 20:20:32 PDT 2011


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 60862: Convert api tester over to using gtest expectations directly
https://bugs.webkit.org/show_bug.cgi?id=60862

Attachment 93597: Patch
https://bugs.webkit.org/attachment.cgi?id=93597&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93597&action=review

> Tools/TestWebKitAPI/PlatformUtilities.h:58
>  std::string toSTD(WKStringRef string);
> +std::string toSTD(WKRetainPtr<WKStringRef> string);
> +std::string toSTD(const char* string);

That StyleQueue is so smart. We should remove those names!


More information about the webkit-reviews mailing list