[webkit-reviews] review granted: [Bug 60859] Make API tester more gtest friendly : [Attachment 93590] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 15 15:38:39 PDT 2011


David Levin <levin at chromium.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 60859: Make API tester more gtest friendly
https://bugs.webkit.org/show_bug.cgi?id=60859

Attachment 93590: Patch
https://bugs.webkit.org/attachment.cgi?id=93590&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93590&action=review

Thanks!

> Tools/Scripts/run-api-tests:94
> +	       $childOut = ">&STDOUT";

You could even move out out of the unless/else, since it is now common between
the two clauses.


More information about the webkit-reviews mailing list