[webkit-reviews] review denied: [Bug 60857] Call AtomicString::init() when initalizing JavaScriptCore : [Attachment 93587] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 15 10:37:35 PDT 2011


Adam Barth <abarth at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 60857: Call AtomicString::init() when initalizing JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=60857

Attachment 93587: Patch
https://bugs.webkit.org/attachment.cgi?id=93587&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Is AtomicString used in JavaScriptCore?  It's not clear to me why
JavaScriptCore should be calling init instead of WebCore.  WTF is an
independent library.

More specifically, this patch will break folks who don't link in
JavaScriptCore.


More information about the webkit-reviews mailing list