[webkit-reviews] review granted: [Bug 60700] Replace direct StringConcatenate usage, by using operator+ (again) : [Attachment 93552] Patch v3

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 60700: Replace direct StringConcatenate usage, by using operator+ (again)
https://bugs.webkit.org/show_bug.cgi?id=60700

Attachment 93552: Patch v3
https://bugs.webkit.org/attachment.cgi?id=93552&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93552&action=review

r=me with some notes.

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:83
> +    return sourceID + ":" + String::number(scriptBreakpoint.lineNumber);

not ':'?

> Source/WebCore/page/DOMWindow.cpp:1702
> +	      " from frame with URL " + activeWindowURL.string() + ". Domains,
protocols and ports must match.\n";

don't we use indention with 4 spaces here? I like your style more, but we
should be consistent.

> Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp:56
> +	   String key = "F" + String::number(i);

'F' instead of "F"?

> Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp:164
> +	   String key = "F" + String::number(i);

Ditto.