[webkit-reviews] review granted: [Bug 59409] Improve drag start logic : [Attachment 93525] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 13 16:11:03 PDT 2011


Tony Chang <tony at chromium.org> has granted Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 59409: Improve drag start logic
https://bugs.webkit.org/show_bug.cgi?id=59409

Attachment 93525: Patch
https://bugs.webkit.org/attachment.cgi?id=93525&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93525&action=review

>
LayoutTests/platform/mac/editing/pasteboard/drag-selections-to-contenteditable.
html:33
> +    log(document.getElementById('target').children[0].tagName);
> +    log(document.getElementById('target').children[1].tagName);
> +    log(document.getElementById('target').children[2].tagName);
> +    log(document.getElementById('target').children[3].tagName);

Nit: It might be good to verify that there are exactly 4 children, although I
guess we'd see the extra output in the text dump.


More information about the webkit-reviews mailing list